-
Notifications
You must be signed in to change notification settings - Fork 623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing release namespace for manila charts #2852
base: master
Are you sure you want to change the base?
Conversation
The manila charts are missing the namespace and when templating things with Helm, it will omit it and be problematic. The cinder chart has the namespaces set everywhere and its better to be explicit so this adds it to the manila chart.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @mnaser. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test @mnaser needs a version bump on https://github.com/kubernetes/cloud-provider-openstack/blob/master/charts/manila-csi-plugin/Chart.yaml#L5 |
@mnaser: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The manila charts are missing the namespace and when templating
things with Helm, it will omit it and be problematic. The cinder
chart has the namespaces set everywhere and its better to be
explicit so this adds it to the manila chart.
What this PR does / why we need it:
Which issue this PR fixes(if applicable):
fixes #
Special notes for reviewers:
Release note: