-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
moving chrisz100 to approver level #6434
Conversation
/assign @justinsb @mikesplain |
/retest |
@chrisz100: GitHub didn't allow me to assign the following users: chrislovecmn. Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Whoops... |
Aws tests are busted because of the testing account. @mikesplain he has met the needed amount of PR reviews and PRs? |
/test pull-kops-e2e-kubernetes-aws |
According to devstats, yes @chrisz100 has completed the required reviews to be bumped to an approver. I think Chris is a strong asset to the project and it would be great get his help keeping up the recent velocity we've achieved. |
Yes, I concur! @chrisz100 remember that with great power comes great responsibility, and ... welcome! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisz100, justinsb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi all, as discussed with @mikesplain I'd love to move the ranks and be allowed to approve in the future.