Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moving chrisz100 to approver level #6434

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

chrisz100
Copy link
Contributor

Hi all, as discussed with @mikesplain I'd love to move the ranks and be allowed to approve in the future.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 1, 2019
@chrisz100
Copy link
Contributor Author

/assign @justinsb @mikesplain

@chrisz100
Copy link
Contributor Author

/retest
/assign @chrislovecmn

@k8s-ci-robot
Copy link
Contributor

@chrisz100: GitHub didn't allow me to assign the following users: chrislovecmn.

Note that only kubernetes members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/retest
/assign @chrislovecmn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrisz100
Copy link
Contributor Author

Whoops...
/assign @chrislovecnm

@chrislovecnm
Copy link
Contributor

Aws tests are busted because of the testing account.

@mikesplain he has met the needed amount of PR reviews and PRs?

@zetaab
Copy link
Member

zetaab commented Feb 16, 2019

/test pull-kops-e2e-kubernetes-aws

@mikesplain
Copy link
Contributor

According to devstats, yes @chrisz100 has completed the required reviews to be bumped to an approver.

I think Chris is a strong asset to the project and it would be great get his help keeping up the recent velocity we've achieved.

@justinsb
Copy link
Member

Yes, I concur! @chrisz100 remember that with great power comes great responsibility, and ... welcome!

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrisz100, justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit da89545 into kubernetes:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants