Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a link in hack/release_notes.sh to the changelog for more details. #11283

Merged

Conversation

andriyDev
Copy link
Contributor

@andriyDev andriyDev commented May 4, 2021

fixes #11278.

Before:

Already up to date.
* Thank PR reviewers and issue-commenters in hack/release_notes.sh. [#11277](https://github.com/kubernetes/minikube/pull/11277)
* site: fixed CPU benchmarking typos and small formatting [#11279](https://github.com/kubernetes/minikube/pull/11279)
* Revert "Run test2json during the test and not afterwards" [#11273](https://github.com/kubernetes/minikube/pull/11273)
* Add minikube prow testing docker image [#11251](https://github.com/kubernetes/minikube/pull/11251)
* Bump github.com/shirou/gopsutil/v3 from 3.21.3 to 3.21.4 [#11259](https://github.com/kubernetes/minikube/pull/11259)
* spelling [#11186](https://github.com/kubernetes/minikube/pull/11186)
* Output GitHub issue message to stderr [#11230](https://github.com/kubernetes/minikube/pull/11230)
* Update olm addon to v0.17.0 [#10947](https://github.com/kubernetes/minikube/pull/10947)
* ci: Make separate image for the remove functional test [#11248](https://github.com/kubernetes/minikube/pull/11248)
* Run test2json during the test and not afterwards [#11250](https://github.com/kubernetes/minikube/pull/11250)
* warn about performance for certain versions of kubernetes [#11217](https://github.com/kubernetes/minikube/pull/11217)
* Fix out stylized function formatting with an empty map instead of nothing. [#11243](https://github.com/kubernetes/minikube/pull/11243)
* Bump github.com/Azure/azure-sdk-for-go from 43.0.0+incompatible to 43.3.0+incompatible [#11261](https://github.com/kubernetes/minikube/pull/11261)
* Bump cloud.google.com/go/storage from 1.13.0 to 1.15.0 [#11263](https://github.com/kubernetes/minikube/pull/11263)
* Bump github.com/hashicorp/go-retryablehttp from 0.6.8 to 0.7.0 [#11260](https://github.com/kubernetes/minikube/pull/11260)
* update releases-beta.json to include v1.20.0-beta.0 [#11244](https://github.com/kubernetes/minikube/pull/11244)
* Fixed gsutil copy for releases-beta.json [#11245](https://github.com/kubernetes/minikube/pull/11245)

Thank you to our contributors for this release!

- Anders F Björklund
- Andriy Dzikh
- dependabot[bot]
- Ilya Zuyev
- Medya Ghazizadeh
- minikube-bot
- Sharif Elgamal
- Steven Powell
- Tomas Kral
- Yanshu
- zhangshj

Thank you to our PR reviewers for this release!

- medyagh (20 comments)
- spowelljr (2 comments)
- afbjorklund (1 comments)

Thank you to our triage members for this release!

- medyagh (18 comments)
- afbjorklund (10 comments)
- andriyDev (5 comments)
- spowelljr (3 comments)
- MullinsN (2 comments)

After:

Already up to date.
* Thank PR reviewers and issue-commenters in hack/release_notes.sh. [#11277](https://github.com/kubernetes/minikube/pull/11277)
* site: fixed CPU benchmarking typos and small formatting [#11279](https://github.com/kubernetes/minikube/pull/11279)
* Revert "Run test2json during the test and not afterwards" [#11273](https://github.com/kubernetes/minikube/pull/11273)
* Add minikube prow testing docker image [#11251](https://github.com/kubernetes/minikube/pull/11251)
* Bump github.com/shirou/gopsutil/v3 from 3.21.3 to 3.21.4 [#11259](https://github.com/kubernetes/minikube/pull/11259)
* spelling [#11186](https://github.com/kubernetes/minikube/pull/11186)
* Output GitHub issue message to stderr [#11230](https://github.com/kubernetes/minikube/pull/11230)
* Update olm addon to v0.17.0 [#10947](https://github.com/kubernetes/minikube/pull/10947)
* ci: Make separate image for the remove functional test [#11248](https://github.com/kubernetes/minikube/pull/11248)
* Run test2json during the test and not afterwards [#11250](https://github.com/kubernetes/minikube/pull/11250)
* warn about performance for certain versions of kubernetes [#11217](https://github.com/kubernetes/minikube/pull/11217)
* Fix out stylized function formatting with an empty map instead of nothing. [#11243](https://github.com/kubernetes/minikube/pull/11243)
* Bump github.com/Azure/azure-sdk-for-go from 43.0.0+incompatible to 43.3.0+incompatible [#11261](https://github.com/kubernetes/minikube/pull/11261)
* Bump cloud.google.com/go/storage from 1.13.0 to 1.15.0 [#11263](https://github.com/kubernetes/minikube/pull/11263)
* Bump github.com/hashicorp/go-retryablehttp from 0.6.8 to 0.7.0 [#11260](https://github.com/kubernetes/minikube/pull/11260)
* update releases-beta.json to include v1.20.0-beta.0 [#11244](https://github.com/kubernetes/minikube/pull/11244)
* Fixed gsutil copy for releases-beta.json [#11245](https://github.com/kubernetes/minikube/pull/11245)

For a more detailed changelog, including changes occuring in pre-release versions, see [CHANGELOG.md](https://github.com/kubernetes/minikube/blob/master/CHANGELOG.md).

Thank you to our contributors for this release!

- Anders F Björklund
- Andriy Dzikh
- dependabot[bot]
- Ilya Zuyev
- Medya Ghazizadeh
- minikube-bot
- Sharif Elgamal
- Steven Powell
- Tomas Kral
- Yanshu
- zhangshj

Thank you to our PR reviewers for this release!

- medyagh (20 comments)
- spowelljr (2 comments)
- afbjorklund (1 comments)

Thank you to our triage members for this release!

- medyagh (18 comments)
- afbjorklund (10 comments)
- andriyDev (5 comments)
- spowelljr (3 comments)
- MullinsN (2 comments)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 4, 2021
@minikube-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@k8s-ci-robot
Copy link
Contributor

Hi @andriyDev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 4, 2021
@k8s-ci-robot k8s-ci-robot requested review from prezha and tstromberg May 4, 2021 22:15
@sharifelgamal
Copy link
Collaborator

Looks like this needs a rebase.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021
@andriyDev andriyDev force-pushed the ReleaseNotesAddChangelogLink branch from 05a5384 to f7e5b6b Compare May 4, 2021 23:18
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021
@andriyDev
Copy link
Contributor Author

@sharifelgamal Done!

@sharifelgamal sharifelgamal merged commit 9143f11 into kubernetes:master May 4, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andriyDev, sharifelgamal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2021
@andriyDev andriyDev deleted the ReleaseNotesAddChangelogLink branch May 5, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hack/release_notes.sh should print a link to the full changelog.
4 participants