Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RowValue which can reference an invalid Ok that defined outside #62

Merged
merged 1 commit into from
Jul 28, 2022

Conversation

importcjj
Copy link
Contributor

No description provided.

@kubo
Copy link
Owner

kubo commented Jul 26, 2022

Thanks!

Could you change tests/procmacro.rs as follows?

  1. Rename fn test_procmacro_ok_shadow() to fn procmacro_ok_shadow()
  2. Add #[allow(dead_code)] to fn procmacro_ok_shadow() to suppress warning: function is never used
  3. Add #[allow(unused_imports)] to use AnotherResult::Ok; to suppress warning: unused import
  4. Run cargo fmt

@kubo
Copy link
Owner

kubo commented Jul 27, 2022

@importcjj
After you removes the empty line between #[allow(dead_code)] and enum AnotherResult<T, E>, could you merge your commits into one by git rebase -i (see here) and git push -f in order to simplify revision history?

This is optional. If you don't, I'll use "squash and merge" instead of "merge commit" (default option). (see here)

Update tests/procmacro.rs

Fix lint attribute
@importcjj
Copy link
Contributor Author

I removed the empty line, actual it doesn't take any effect.

@importcjj importcjj changed the title Fix RowValue which can reference a invalid Ok that defined outside Fix RowValue which can reference an invalid Ok that defined outside Jul 28, 2022
@kubo kubo merged commit ba36fa0 into kubo:master Jul 28, 2022
@kubo
Copy link
Owner

kubo commented Jul 28, 2022

Thanks for contribution.

I'll release 0.5.6 this weekend or the next weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants