Extend compatibility with newer version of psr/log:"^1.1.2|^2.0|^3.0" #50
Conversation
Signed-off-by: Frank Brückner <[email protected]> Signed-off-by: Ionut Cioflan <[email protected]>
- Remove dependency to \Psr\Log\Test\LoggerInterfaceTest Signed-off-by: Ionut Cioflan <[email protected]>
String "Laminas\Log\Writer\Firephp" contains class reference, use ::class instead Signed-off-by: Ionut Cioflan <[email protected]>
| * @throws InvalidArgumentException If log level is not recognized. | ||
| */ | ||
| public function log($level, $message, array $context = []) | ||
| public function log($level, $message, array $context = []): void |
There was a problem hiding this comment.
Let's please not add type information where it would break subclasses
There was a problem hiding this comment.
I had to add this because this was enforced by in psr/log 3.0
https://github.com/php-fig/log/blob/3.0.0/src/LoggerTrait.php
There was a problem hiding this comment.
Also, I was thinking that this was just a wrapper to offer compatibility from laminas/log to psr/log ... most likely it was used as is, but you are right, it can break sub classes..
There was a problem hiding this comment.
Does it make sense to put additional effort into this (make different branch for targeting different psr/log versions)?
There was a problem hiding this comment.
I think this component should really not be touched: moving to Monolog\Monolog is endorsed.
There was a problem hiding this comment.
I think this component should really not be touched: moving to
Monolog\Monologis endorsed.
Understoo, thank you.
|
Hmm, this component is security-only, and shouldn't receive new updates 🤔 |
I've tried to make it compatible. Because it targets psr/log: 1.* it may be conflicting with other libraries that may choose to use newer versions. I can accept that it's security-only ... and use the fork as a replacement package. |
Description
Extend compatibility with newer version of psr/log:"^1.1.2|^2.0|^3.0"
\LaminasTest\Log\PsrLoggerAdapterTest, removed dependency on\Psr\Log\Test\LoggerInterfaceTest(it was removed in newer versions).