Adopt Laminas CI Workflow

[fezfez]

like ask in #18

[fezfez]

@froschdesign : i've generate the composer.lock from my local machine on php 7.4 with simple composer update but i see some jobs failed due to this composer.lock (php5.6 job) how to generate a composer.lock that will work for all php version ?

with composer update --prefer-lowest ?

[fezfez]

it seem that with composer update --prefer-lowest it does not work with recent php version... how to deal with it ?

[nusphere]

doesn't it make more sense to completely exclude composer.lock? a composer install would then install the appropriate packages.

[nusphere]

i would love to see this merge. I'll deal with the review today - maybe it will help to speed up the merge.

[nusphere]

This is my first review here.

[froschdesign]

@fezfez
Sorry for the late response but now we have the exact steps to add the GitHub action for the CI workflow.

Please see: https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4

[fezfez]

I'll check this after my vacation in 1 week

[fezfez]

@weierophinney : ready to another review

[fezfez]

ping :)

[samsonasik]

@fezfez please target to 3.5.x branch, thank you.

[samsonasik]

I changed target to 3.5.x branch

[fezfez]

@samsonasik i've created a new pr to target 3.5.x, see #28 , closing this

[Xerkus]

@fezfez please target to 3.5.x branch, thank you.

@samsonasik I think there was a miscommunication, see #19 (comment)
It is in folded comment

[samsonasik]

@Xerkus that seems implemented at #28

[Xerkus]

You missed the point. Matthew wanted it for patch release, per that comment

[Xerkus]

sorry, I'm from the phone.
@samsonasik IIRC Matthew requested it to be against 3.4 branch. Is it still what is wanted or were his concerns addressed?

[samsonasik]

@Xerkus oh, you're correct. I just look other PR in other repos that update to CI workflow as next minor release, because "remove file headers" is a minor release as well.