-
Notifications
You must be signed in to change notification settings - Fork 17.3k
core[patch]: update dict prompt template #30967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
from langchain_core.runnables.config import ensure_config | ||
|
||
|
||
class DictPromptTemplate(RunnableSerializable[dict, dict]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note: no longer inherits from BaseMessagePromptTemplate since thats not really how its used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a future minor release, if we want to use this template for all messages (as was done originally in #25674), would it be easier to keep that around?
I also sympathize for reducing complexity and just implementing when we need it, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaict this was just never deleted after it was copied to core and isn't needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should close #26701
from langchain_core.runnables.config import ensure_config | ||
|
||
|
||
class DictPromptTemplate(RunnableSerializable[dict, dict]): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in a future minor release, if we want to use this template for all messages (as was done originally in #25674), would it be easier to keep that around?
I also sympathize for reducing complexity and just implementing when we need it, though.
Align with JS changes made in langchain-ai/langchainjs#8043