Skip to content

community[patch]: Add support for exists filter in the elasticsearch vector store. #4541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

joachimvandenabeele
Copy link
Contributor

This PR adds support for filtering with "exists" for the elasticsearch vector store.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Feb 27, 2024
Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 8:40am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Feb 28, 2024 8:40am

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Feb 27, 2024
@jacoblee93 jacoblee93 changed the title Add support for exists filter in the elasticsearch vector store. community[patch]: Add support for exists filter in the elasticsearch vector store. Feb 28, 2024
@jacoblee93
Copy link
Collaborator

LGTM, thanks!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Feb 28, 2024
@jacoblee93
Copy link
Collaborator

Hey @joachimvandenabeele, could you run yarn format to get CI passing? I can't push to your branch.

@jacoblee93
Copy link
Collaborator

Thank you!

@joachimvandenabeele
Copy link
Contributor Author

My pleasure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants