Skip to content

core[minor]: Add JSON functions output parser to core #4546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

bracesproul
Copy link
Member

No description provided.

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2024 5:53pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Feb 27, 2024 5:53pm

...functionCall,
arguments: parsePartialJson(functionCall.arguments),
// eslint-disable-next-line @typescript-eslint/no-explicit-any
} as Record<string, any> as Output;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @jacoblee93 I had to add this cast because functionCall does not overlap enough with Record<string, any> for some reason...

@bracesproul bracesproul marked this pull request as ready for review February 27, 2024 17:42
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Feb 27, 2024
@bracesproul bracesproul merged commit 9f74a8b into main Feb 27, 2024
@bracesproul bracesproul deleted the brace/move-json-functions-core branch February 27, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant