Skip to content

groq[patch]: Set dangerouslyAllowBrowser = true in ChatGroq #4571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

groq[patch]: Set dangerouslyAllowBrowser = true in ChatGroq #4571

merged 1 commit into from
Feb 28, 2024

Conversation

gradenr
Copy link
Contributor

@gradenr gradenr commented Feb 28, 2024

Fixes # (issue)

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 4:58pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Feb 28, 2024 4:58pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Feb 28, 2024
dosubot[bot]
dosubot bot reviewed Feb 28, 2024
View reviewed changes
libs/langchain-groq/src/chat_models.ts
@@ -17,18 +15,20 @@ import {
SystemMessageChunk,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I've reviewed the code and noticed that the recent change adds an import for getEnvironmentVariable from "@langchain/core/utils/env", which may indicate the use of environment variables. I've flagged this for your review. Let me know if you have any questions!

Copy link
Contributor Author

@gradenr gradenr Feb 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imports were sorted, but otherwise unchanged.

bracesproul
bracesproul approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Will merge & cut a release once CI passes

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Feb 28, 2024
@bracesproul bracesproul changed the title Set dangerouslyAllowBrowser = true in ChatGroq groq[patch]: Set dangerouslyAllowBrowser = true in ChatGroq Feb 28, 2024
@bracesproul bracesproul merged commit 1ab880f into langchain-ai:main Feb 28, 2024
@gradenr gradenr deleted the graden/groq-dangerously-allow branch February 28, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosubot dosubot[bot] dosubot[bot] left review comments

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gradenr @bracesproul