Skip to content

community[patch]: Add maxTokens to _streamResponseChunks options in llama_cpp.ts #4591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

adamkdean
Copy link
Contributor

This PR introduces the missing maxTokens option to _streamResponseChunks.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Feb 29, 2024
Copy link

vercel bot commented Feb 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 11:49pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Feb 29, 2024 11:49pm

@dosubot dosubot bot added the auto:improvement Medium size change to existing code to handle new use-cases label Feb 29, 2024
@adamkdean adamkdean changed the title Add maxTokens to _streamResponseChunks options in llama_cpp.ts community[patch]: Add maxTokens to _streamResponseChunks options in llama_cpp.ts Feb 29, 2024
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this, good catch!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants