-
Notifications
You must be signed in to change notification settings - Fork 2.4k
docs[minor]: Simplify docs build #4607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm w/ one comment
package.json
Outdated
@@ -34,7 +34,7 @@ | |||
"test:exports:docker": "docker compose -f environment_tests/docker-compose.yml up --force-recreate", | |||
"example": "yarn workspace examples start", | |||
"precommit": "turbo run precommit", | |||
"docs": "yarn workspace core_docs start", | |||
"docs": "cd docs/core_docs && yarn workspace core_docs start", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't believe you need this cd
because you already have yarn workspace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yeah prob not
CC @bracesproul