Skip to content

docs[minor]: Simplify docs build #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2024
Merged

docs[minor]: Simplify docs build #4607

merged 4 commits into from
Mar 4, 2024

Conversation

jacoblee93
Copy link
Collaborator

@jacoblee93 jacoblee93 commented Mar 4, 2024

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 4, 2024
Copy link

vercel bot commented Mar 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:18am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 4, 2024 4:18am

@dosubot dosubot bot added the auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder label Mar 4, 2024
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm w/ one comment

package.json Outdated
@@ -34,7 +34,7 @@
"test:exports:docker": "docker compose -f environment_tests/docker-compose.yml up --force-recreate",
"example": "yarn workspace examples start",
"precommit": "turbo run precommit",
"docs": "yarn workspace core_docs start",
"docs": "cd docs/core_docs && yarn workspace core_docs start",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't believe you need this cd because you already have yarn workspace

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah prob not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants