Skip to content

mongodb[minor]: MongoDBStore #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 13, 2024
Merged

mongodb[minor]: MongoDBStore #4706

merged 7 commits into from
Mar 13, 2024

Conversation

bracesproul
Copy link
Member

@vercel Vercel
Copy link

vercel bot commented Mar 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 4:22pm
langchainjs-docs 🛑 Canceled (Inspect) Mar 13, 2024 4:22pm

@bracesproul bracesproul marked this pull request as ready for review March 11, 2024 02:09
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Mar 11, 2024
dosubot[bot]
dosubot bot reviewed Mar 11, 2024
View reviewed changes
libs/langchain-mongodb/package.json
@@ -65,7 +66,8 @@
"release-it": "^15.10.1",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I noticed that the latest PR added a new dependency "uuid" to the project. This change is flagged for maintainers to review and confirm if it affects any peer/dev/hard dependencies. Keep up the great work! 🚀

dosubot[bot]
dosubot bot reviewed Mar 11, 2024
View reviewed changes
libs/langchain-mongodb/src/tests/storage.int.test.ts
@@ -0,0 +1,223 @@
/* eslint-disable no-process-env */
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just a heads up that I've flagged a change in the PR for review. The added code explicitly accesses the environment variable MONGODB_ATLAS_URI using process.env, so it's important to ensure this is handled correctly.

@jacoblee93
Copy link
Collaborator

Thanks, see comments

@jacoblee93 jacoblee93 added the close PRs that need one or two touch-ups to be ready label Mar 12, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit 79a04e0 into main Mar 13, 2024
@jacoblee93 jacoblee93 deleted the brace/mongo-store branch March 13, 2024 17:40
@jacoblee93 jacoblee93 added lgtm PRs that are ready to be merged as-is and removed close PRs that need one or two touch-ups to be ready labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 left review comments

@dosubot dosubot[bot] dosubot[bot] left review comments

Assignees
No one assigned
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bracesproul @jacoblee93