core[patch]: Update ai.ts #5099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code currently only checks for undefined on rawToolCalls. However, the provider can return toolCalls=null, which passed the conditional but will then produce an error when rawToolCalls.length is accessed.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:XS
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In langchain-core/src/messages/ai.ts
The code currently only checks for undefined on rawToolCalls. However, the provider (deep-infra in this case) can return toolCalls=null, which passed the conditional but will then produce an error when rawToolCalls.length is accessed.
Changed the conditional to !(rawToolCalls == null) to address the issue, and verified that this fixed the issue.
Note that
rawToolCalls == nullis true if rawToolCalls is null OR undefined, thus handling both cases.