-
Notifications
You must be signed in to change notification settings - Fork 2.4k
fix handling of multibyte characters in streams for google-gauth #5286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix handling of multibyte characters in streams for google-gauth #5286
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@@ -8,12 +8,19 @@ import { | |||
} from "@langchain/google-common"; | |||
import { GoogleAuth, GoogleAuthOptions } from "google-auth-library"; | |||
|
|||
class NodeJsonStream extends JsonStream { | |||
export class NodeJsonStream extends JsonStream { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I exported this because it seemed complex to test while mocking GAuthClient
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, cc @afirstenberg for another look
LGTM |
Thank you for reviewing & quick release! |
Fixes #5285