fix(google-common): Handle multiple function calls and complex parts/generations #7706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The combineGenerations() function has much of its work, but also splits things up so that content, text, toolCalls, and kwargs are now combined in a more reasonable way.
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jacoblee93
reviewed
Feb 20, 2025
jacoblee93
reviewed
Feb 20, 2025
jacoblee93
reviewed
Feb 20, 2025
|
|
||
| gen.forEach((item: ChatGeneration) => { | ||
| const message: AIMessageChunk = item?.message as AIMessageChunk; | ||
| ret.tool_calls!.push(...(message?.tool_calls ?? [])); |
There was a problem hiding this comment.
Is this really what we want to do vs. just chunks?
Will each item have unique tool calls?
We do have a concat method internally that handles this:
import { concat } from "@langchain/core/utils/stream";
const combinedChunk = concat(chunk1, chunk2);There was a problem hiding this comment.
I think it is (although I've changed it to use concat(). Certainly this seems to be at least part of the issue that was reported.
I've added a comment to make it more clear that the AIMessageChunk isn't really the objective here - it is just a convenient object to carry all the tool calling related arrays.
…en't implemented by Google now).
And thank you for reviewing! Hopefully these three updates address all the issues. |
jacoblee93
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup responseToChatGenerations() so it is more readable.
The combineGenerations() function has much of its work, but also splits things up so that content, text, toolCalls, and kwargs are now combined in a more reasonable way.
The previous implementation only handled cases where there was one function call and there was no text content along with it. And it did it in a huge loop over all the parts that was difficult to untangle.
These changes clean things up, separate some of the logic so it is clearer what is going on, and handles multiple parts better. It also sets things up so future changes can handle new part types easier.
Fixes #7705