Skip to content

feat(community): add deepseek to allowed bedrock models #7842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 15, 2025

Conversation

jarib
Copy link
Contributor

@jarib jarib commented Mar 13, 2025

See https://aws.amazon.com/blogs/aws/deepseek-r1-now-available-as-a-fully-managed-serverless-model-in-amazon-bedrock/

IMHO this validation of model providers is redundant. Bedrock will let the user know if the model is invalid. Strictly enforcing it in client libs makes no sense to me.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Mar 13, 2025
Copy link

vercel bot commented Mar 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 13, 2025 5:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Mar 13, 2025 5:55pm

@dosubot dosubot bot added the auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs label Mar 13, 2025
@jacoblee93
Copy link
Collaborator

I agree with you - want to just remove them?

@jacoblee93
Copy link
Collaborator

Actually I notice this is not present in @langchain/aws which is what most people should be using going forwards - let's just merge this as is

@jarib
Copy link
Contributor Author

jarib commented Mar 13, 2025

Ah, I wasn't aware of @langchain/aws. Will look into it. Fixed the formatting failure here anyway :)

@jacoblee93 jacoblee93 changed the title add deepseek to allowed bedrock models feat(community): add deepseek to allowed bedrock models Mar 15, 2025
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Mar 15, 2025
@jacoblee93 jacoblee93 merged commit b8d8af5 into langchain-ai:main Mar 15, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants