Client configurations outdated(vue.config.js)

[robbykrlos]

This is a bug?.

Prerequisites

• Are you running the latest version?
• Are you reporting to the correct repository?
• Did you check the documentation?
• Did you perform a cursory search?

Description

While investigating this #352 - I have checked some files from client side - just to be sure we're in sync.

Not sure if a bug or not, but shouldn't the laravel-enso/enso configuration released in 4.6.0 reflect the latest configuration changes (with all required changes from all upgrade steps 4.1 ... 4.4, 4.5, 4.6?

My logic says that a new enso installation will not work, due to @ui / @core alias missmatches. But maybe I'm wrong.

Latest package (one example file)

enso/client/vue.config.js

Line 40 in 6e6f14c

'@core': `${__dirname}/node_modules/@enso-ui/ui/src`,

Release notes from 4.4.0:

the @core alias has been renamed to @ui, so update all usages, including

• local resources (pages, components)
• the client/.eslintrc.js file
  ...

PS: I've found one file, but could be more, didn't check all configs.

[raftx24]

Hi @robbykrlos.
Yes, you are right, even though we don't use @ui here but anyway we should use @ui in .eslintrc.js too.
could you please create a PR for it?
thank you

[robbykrlos]

Sure. Will do.

[robbykrlos]

Yes, you are right, even though we don't use @ui here but anyway we should use @ui in .eslintrc.js too.

Hi again,

So now that I'm actually doing this, I further more confused by your last comment:

So, my initial ticket was related to vue.config.js - which had a bad outdated alias - which I fixed by PR #373

.eslintrc.js has no problem from what I see, the alias is correct in this file:

alias: {
                map: [
                    ['@ui', `${__dirname}/node_modules/@enso-ui/ui/src`],
                    ['@root', `${__dirname}/src/js`],

Probably typo and you meant vue.config.js?