Skip to content

Redirect to intended URL after email verification #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public function store(Request $request)
if ($request->user()->hasVerifiedEmail()) {
return $request->wantsJson()
? new JsonResponse('', 204)
: redirect(config('fortify.home'));
: redirect()->intended(config('fortify.home'));
}

$request->user()->sendEmailVerificationNotification();
Expand Down
2 changes: 1 addition & 1 deletion src/Http/Controllers/EmailVerificationPromptController.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class EmailVerificationPromptController extends Controller
public function __invoke(Request $request)
{
return $request->user()->hasVerifiedEmail()
? redirect(config('fortify.home'))
? redirect()->intended(config('fortify.home'))
: app(VerifyEmailViewResponse::class);
}
}
4 changes: 2 additions & 2 deletions src/Http/Controllers/VerifyEmailController.php
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ class VerifyEmailController extends Controller
public function __invoke(VerifyEmailRequest $request): RedirectResponse
{
if ($request->user()->hasVerifiedEmail()) {
return redirect(config('fortify.home').'?verified=1');
return redirect()->intended(config('fortify.home').'?verified=1');
}

if ($request->user()->markEmailAsVerified()) {
event(new Verified($request->user()));
}

return redirect(config('fortify.home').'?verified=1');
return redirect()->intended(config('fortify.home').'?verified=1');
}
}
16 changes: 16 additions & 0 deletions tests/EmailVerificationNotificationControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,20 @@ public function test_user_is_redirect_if_already_verified()

$response->assertRedirect('/home');
}

public function test_user_is_redirect_to_intended_url_if_already_verified()
{
$user = Mockery::mock(Authenticatable::class);

$user->shouldReceive('hasVerifiedEmail')->andReturn(true);
$user->shouldReceive('getAuthIdentifier')->andReturn(1);
$user->shouldReceive('sendEmailVerificationNotification')->never();

$response = $this->from('/email/verify')
->actingAs($user)
->withSession(['url.intended' => 'http://foo.com/bar'])
->post('/email/verification-notification');

$response->assertRedirect('http://foo.com/bar');
}
}
30 changes: 30 additions & 0 deletions tests/EmailVerificationPromptControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,4 +22,34 @@ public function test_the_email_verification_prompt_view_is_returned()
$response->assertStatus(200);
$response->assertSeeText('hello world');
}

public function test_user_is_redirect_home_if_already_verified()
{
$this->mock(VerifyEmailViewResponse::class)
->shouldReceive('toResponse')
->andReturn(response('hello world'));

$user = Mockery::mock(Authenticatable::class);
$user->shouldReceive('hasVerifiedEmail')->andReturn(true);

$response = $this->actingAs($user)->get('/email/verify');

$response->assertRedirect('/home');
}

public function test_user_is_redirect_to_intended_url_if_already_verified()
{
$this->mock(VerifyEmailViewResponse::class)
->shouldReceive('toResponse')
->andReturn(response('hello world'));

$user = Mockery::mock(Authenticatable::class);
$user->shouldReceive('hasVerifiedEmail')->andReturn(true);

$response = $this->actingAs($user)
->withSession(['url.intended' => 'http://foo.com/bar'])
->get('/email/verify');

$response->assertRedirect('http://foo.com/bar');
}
}
6 changes: 4 additions & 2 deletions tests/VerifyEmailControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,11 @@ public function test_the_email_can_be_verified()
$user->shouldReceive('hasVerifiedEmail')->andReturn(false);
$user->shouldReceive('markEmailAsVerified')->once();

$response = $this->actingAs($user)->get($url);
$response = $this->actingAs($user)
->withSession(['url.intended' => 'http://foo.com/bar'])
->get($url);

$response->assertStatus(302);
$response->assertRedirect('http://foo.com/bar');
}

public function test_redirected_if_email_is_already_verified()
Expand Down