[8.x] Do not use foundation helper on auth component

[rodrigopedra]

While skimming through closed issues, I saw that issue #35718 references PR #34808. From that PR code I noticed the EnsureEmailIsVerified uses the abort helper, but this class is from the Illuminate\Auth component which can be used outside of Laravel.

I searched for other places where the abort helper could be used and didn't found any.

I tried to replicate the same code from Illuminate\Foundation\Application@abort

[sebdesign]

@rodrigopedra you should also check #34817. It seems that some foundation helpers are allowed (like abort) while some others are not. But I couldn't find documentation or feedback about the correct practices.

[GrahamCampbell]

All foundation helpers should be avoided, where practical.

[taylorotwell]

In general I allow them in middleware because I see middleware as very "Laravel integrated" and Laravel's middleware are not typically something that would be just dropped into another framework.

[rodrigopedra]

Makes sense, thank you @taylorotwell for the heads up.