Bypass auth screen if we already have a token #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return $client->tokens() | ||
| ->whereUserId($user->id) | ||
| ->whereRevoked(0) | ||
| ->where('expires_at', '>', Carbon::now()->toDateTimeString()) |
There was a problem hiding this comment.
I'm not sure you really need to make a string, you can just pass in the Carbon instance.
|
Yay! Thanks for this @themsaid! |
|
@jbrooksuk welcome :) |
|
@themsaid is this no longer supported on latest version? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #16
This PR skips the approval screen if the user has a valid token for the same client that has the same scope as the scope requested, Passport will auto-approve the request and return a new token.