feat: Add environment ID support for hooks. #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Mar 4, 2025
| @@ -84,7 +85,7 @@ internal DataSourceUpdatesImpl( | |||
| StateSince = DateTime.Now, | |||
| LastError = null | |||
| }; | |||
| _status = new StateMonitor<DataSourceStatus, StateAndError>(initialStatus, MaybeUpdateStatus, _log); | |||
| _status = new StateMonitor<DataSourceStatus, StateAndError>(initialStatus, MaybeUpdateStatus, _log); | |||
There was a problem hiding this comment.
Just a whitespace change.
kinyoklion
commented
Mar 4, 2025
| #region IDataSourceUpdatesHeaders methods | ||
| public bool InitWithHeaders(FullDataSet<ItemDescriptor> allData, IEnumerable<KeyValuePair<string, IEnumerable<string>>> headers) | ||
| { | ||
| ImmutableDictionary<DataKind, ImmutableDictionary<string, ItemDescriptor>> oldData = null; |
There was a problem hiding this comment.
Most of the method body is from the original init.
tanderson-ld
reviewed
Mar 5, 2025
tanderson-ld
approved these changes
Mar 19, 2025
kinyoklion
pushed a commit
that referenced
this pull request
Mar 21, 2025
🤖 I have created a release *beep* *boop* --- ## [8.7.0](LaunchDarkly.ServerSdk-v8.6.0...LaunchDarkly.ServerSdk-v8.7.0) (2025-03-20) ### Features * Add environment ID support for hooks. ([#81](#81)) ([49149f2](49149f2)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pipes the support for the environment ID header from the event source, through the data sources, and into the data store, and then exposes it to the evaluation series hook context.
Each step can optionally support the environment ID/headers for compatibility.
This PR will be held for back-end support and testing.