feat: Add environment id support for the OTEL hook. #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Mar 21, 2025
| @@ -37,7 +37,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <PackageReference Include="LaunchDarkly.ServerSdk" Version="8.*" /> | |||
| <PackageReference Include="LaunchDarkly.ServerSdk" Version="[8.7, 9.0)" /> | |||
There was a problem hiding this comment.
Hook 1.1.0 will require SDK 8.7.0 or greater. I constrained to less than 9 for now.
tanderson-ld
approved these changes
Mar 21, 2025
kinyoklion
force-pushed
the
rlamb/emsr-129/otel-hook-environment-id
branch
from
1bdbd25 to
32da919
Compare
kinyoklion
changed the title
kinyoklion
pushed a commit
that referenced
this pull request
Mar 24, 2025
🤖 I have created a release *beep* *boop* --- ## [1.1.0](LaunchDarkly.ServerSdk.Telemetry-v1.0.0...LaunchDarkly.ServerSdk.Telemetry-v1.1.0) (2025-03-24) ### Features * Add environment id support for the OTEL hook. ([#82](#82)) ([c2ed519](c2ed519)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will need to be merged after the base PR, and the version required by the hook will need updated.