chore: adds CompositeDataSource for FDv2 support #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
changed the title
kinyoklion
reviewed
Feb 21, 2025
tanderson-ld
commented
Feb 24, 2025
kinyoklion
requested changes
Mar 4, 2025
packages/shared/common/src/api/subsystem/DataSystem/CallbackHandler.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
kinyoklion
requested changes
Mar 14, 2025
packages/shared/common/src/api/subsystem/DataSystem/CallbackHandler.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
packages/shared/common/src/api/subsystem/DataSystem/CompositeDataSource.ts
Outdated
Show resolved
Hide resolved
| @@ -43,7 +43,7 @@ | |||
| "test": "echo Please run tests for individual packages.", | |||
| "coverage": "npm run test -- --coverage", | |||
| "contract-test-service": "npm --prefix contract-tests install && npm --prefix contract-tests start", | |||
| "contract-test-harness": "curl -s https://raw.githubusercontent.com/launchdarkly/sdk-test-harness/master/downloader/run.sh \\ | VERSION=v2 PARAMS=\"-url http://localhost:8000 -debug -stop-service-at-end $TEST_HARNESS_PARAMS\" sh", | |||
| "contract-test-harness": "curl -s https://raw.githubusercontent.com/launchdarkly/sdk-test-harness/master/downloader/run.sh \\ | VERSION=v2 PARAMS=\"-url http://localhost:8000 -debug --skip-from=./contract-tests/testharness-suppressions.txt -stop-service-at-end $TEST_HARNESS_PARAMS\" sh", | |||
There was a problem hiding this comment.
NON-BLOCKING: Did you intend to commit this or was it just left over from debugging?
| // these local variables are used for handling automatic transition related to data source status (ex: recovering to primary after | ||
| // secondary has been valid for N many seconds) | ||
| let lastState: DataSourceState | undefined; | ||
| let cancelScheduledTransition: () => void = () => {}; |
There was a problem hiding this comment.
It's difficult to tell but this might be problematic. Consider the case where this is pushed to _cancelTokens more than once. Since _consumeCancelToken() removes the token using indexOf which finds the element by strict equality, it would only find and remove the first instance.
abarker-launchdarkly
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
I have added test coverage for new or changed functionality
I have followed the repository's pull request submission guidelines
I have validated my changes against all supported platform versions
Will be done on target temp branch eventually.
Related issues
SDK-857