chore: Adds LDDataSystemOptions for configuring the Data System. #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanderson-ld
commented
Mar 17, 2025
| updateProcessorFactory: TypeValidators.Function.is(validatedOptions.updateProcessor) | ||
| ? validatedOptions.updateProcessor | ||
| : () => validatedOptions.updateProcessor, | ||
| }; |
There was a problem hiding this comment.
For reviewers: Not sure if we need to continue maintaining these ts-ignore annotations due to the types of the inputs being "object | function". I think we do need to maintain them, perhaps you know off the top of your head @kinyoklion
tanderson-ld
commented
Mar 17, 2025
| initSuccessHandler: VoidFunction, | ||
| errorHandler?: (e: Error) => void, | ||
| ) => subsystem.LDStreamProcessor; | ||
| } |
There was a problem hiding this comment.
Investigate if these should be readonly.
tanderson-ld
commented
Mar 17, 2025
| isStreamingOptions(config.dataSystem.dataSource)) && | ||
| config.dataSystem.dataSource.streamInitialReconnectDelay | ||
| ? { reconnectTimeMillis: config.dataSystem.dataSource.streamInitialReconnectDelay } | ||
| : null), |
There was a problem hiding this comment.
For reviewers: This part got a little ugly since now some of these options may not be present. Is there a cleaner way to omit these members?
tanderson-ld
commented
Mar 17, 2025
| this.featureStoreFactory = () => validatedOptions.featureStore; | ||
| } | ||
|
|
||
| this.hooks = validatedOptions.hooks; |
There was a problem hiding this comment.
For reviewers: Hooks was moved up. UpdateProcessorFactory and FeatureStoreFactory was moved up to be near the data system logic.
tanderson-ld
force-pushed
the
ta/sdk-1073/datasystem-config
branch
from
e669f87 to
d186358
Compare
tanderson-ld
force-pushed
the
ta/sdk-1073/datasystem-config
branch
from
d186358 to
bb47dde
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
I have added test coverage for new or changed functionality
I have followed the repository's pull request submission guidelines
I have validated my changes against all supported platform versions
Will be done on target temp branch eventually.
Related issues
SDK-857 and SDK-1073