Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we loosen the semver requirement to include version 3.0? #214

Closed
bkodes opened this issue Aug 1, 2023 · 3 comments
Closed

Can we loosen the semver requirement to include version 3.0? #214

bkodes opened this issue Aug 1, 2023 · 3 comments
Labels
waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.

Comments

@bkodes
Copy link

bkodes commented Aug 1, 2023

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I would love to see the SDK [...does something new...]
Hey I am utilizing ld python sdk but i have conflicting semver versions with lancedb. Is there any chance we can loosen the requirement on semver here to include =<3.0 instead of <3.0?

Describe the solution you'd like
A clear and concise description of what you want to happen.
Can we evaluate what is needed to include semver 3.0? Version vs VersionInfo is my biggest conflict right now with your packages

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
I will do whatever work needs to be done if we are okay with this

Additional context
Add any other context about the feature request here.

@keelerm84
Copy link
Member

This SDK does not have a requirement on lancedb. It seems like this is more likely a problem with transitive dependencies. If you can make a small reproduction case, and send me the requirements.txt file, I can see if there is something we can do on our side.

@keelerm84 keelerm84 added the waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness. label Aug 1, 2023
@bkodes
Copy link
Author

bkodes commented Aug 1, 2023

@keelerm84 hey sorry maybe i wasn't clear with my description. The issue is a dep conflict with semver between launchdarkly and lancedb requirements, not this sdk having a requirement on lancedb.
for more context, lancedb utilizes semver.Version for checking their pydantic verisioning and this is because they have upgraded to semver version >=3.0. VersionInfo has become Version in semver 3.0 and higher. I get a build error with my project because launchdarkly python sdk has a constraint on semver keeping the version below 3.0. It's okay tho I forked this repo and changed the requirement on semver :) Thanks for the quick feedback tho

@bkodes bkodes closed this as completed Aug 3, 2023
@pierre-wehbe
Copy link

@keelerm84 Can we please re-open this.

File: https://github.com/launchdarkly/python-server-sdk/blob/main/requirements.txt
Current dependency: semver>=2.10.2,<3.0.0
Need: semver 3.0.1 (latest version here: https://pypi.org/project/semver/)

Can we loosen the semver requirement to include version 3.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for feedback Indicates LaunchDarkly is waiting for customer feedback before issue is closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants