Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desktop: Accessibility: Fix unlabelled toolbar button in the Rich Text Editor #11655

Merged
merged 1 commit into from
Jan 18, 2025
Merged

Desktop: Accessibility: Fix unlabelled toolbar button in the Rich Text Editor #11655

merged 1 commit into from
Jan 18, 2025

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Jan 15, 2025 •
edited
Loading

Summary

This pull request fixes a missing label in the TinyMCE toolbar.

Related WCAG guidelines

Among other requirements, WCAG 2.2 SC 1.1.1 states,

If non-text content is a control or accepts user input, then it has a name that describes its purpose.

Testing plan

Linux:

  1. Ensure that alt-F10 isn't a shortcut handled by the OS.
  2. Enable the Orca screen reader.
  3. Open the Rich Text Editor.
  4. Press alt-F10.
  5. Verify that Orca reads "Bold, togglebutton not pressed".
  6. Press the right arrow key repeatedly until Orca reads "Formatting, collapsed, button, opens menu".

@personalizedrefrigerator personalizedrefrigerator mentioned this pull request Jan 15, 2025
Open
@personalizedrefrigerator personalizedrefrigerator added desktop All desktop platforms accessibility Related to accessibility labels Jan 15, 2025
@laurent22 laurent22 merged commit c357b77 into laurent22:dev Jan 18, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
accessibility Related to accessibility desktop All desktop platforms
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@personalizedrefrigerator @laurent22