iOS: Re-Add iOS Dark Icon #11943
Open
iOS: Re-Add iOS Dark Icon #11943
+1,007
−567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurent22
reviewed
Mar 8, 2025
Should this be IosAppIconContents then? |
What we do usually is to add an exception here: Line 287 in a39b51c |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-Up to #11460 (comment)
Same as that PR:
Implements the dark icon for iOS 18, and converts the AppIcon asset to use the "All Sizes" format rather than "All Sizes (Xcode 13)" format.
I may have misunderstood what the Single Size format was for, still not entirely sure since I can't find more documentation.
Also some changes were made to the icon generation script to avoid having to keep copying each asset.
These changes can be applied to the other icon sets in a future PR if necessary.