Skip to content

Rework resuming #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Mar 5, 2025
Merged

Rework resuming #32

merged 13 commits into from
Mar 5, 2025

Conversation

freyacodes
Copy link
Member

@freyacodes freyacodes commented Feb 17, 2025

This PR includes the following changes:

  • Adds caching of the Session entity, used by the disconnect code
  • If resuming is configured on the server, the client will wait with moving the links to a different node until the first unsuccessful connection attempt
  • If a connection is successfully resumed, the client will refresh the player and link state
  • Added the new ResumeSynchronizationEvent event after refreshing remote state after a resume
  • Added LavalinkNode#getCachedPlayers()
  • Potentially breaking: ClientEvent is no longer sealed

Not tested since 8edae46

@freyacodes freyacodes requested a review from duncte123 February 17, 2025 16:04
Copy link
Collaborator

@duncte123 duncte123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If we really wanted we could add that get endpoint for the session and push a major version of this client that only supports that new version of the server. That would also remove the possible breaking concern of the non sealed class

@freyacodes
Copy link
Member Author

This seems to be working consistently now

@duncte123 duncte123 merged commit 98d2c58 into main Mar 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants