-
Notifications
You must be signed in to change notification settings - Fork 9
Rework resuming #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework resuming #32
Conversation
NB: This is potentially breaking as it replaces a `sealed` attribute
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. If we really wanted we could add that get endpoint for the session and push a major version of this client that only supports that new version of the server. That would also remove the possible breaking concern of the non sealed class
Also manages the LinkState a bit more consistently
Only if one doesn't already exist for the guild
Conflict because of 87cba00
This seems to be working consistently now |
This PR includes the following changes:
Session
entity, used by the disconnect codeResumeSynchronizationEvent
event after refreshing remote state after a resumeLavalinkNode#getCachedPlayers()
ClientEvent
is no longer sealedNot tested since 8edae46