kappa calculation moved from initial equation to binding equation #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes OpenModelica/OpenModelica#12677. A small drawback of this solution is that the I think OMC should be smart enough to figure out that they are the same function call and factor it out. Even if it doesn't, I understand the overhead of calling that function twice is marginal, considering that the extra computation is performed only once during initialization. |
mwetter
merged commit a9469e0
into
lbl-srg:issue_omc_12677_initialEquation
2 of 3 checks passed
|
Thanks for the change. I will process it from here and merge it to the master branch. |
mwetter
added a commit
that referenced
this pull request
Mar 10, 2025
* kappa calculation moved from initial equation to binding equation (#4130) * Enabled models --------- Co-authored-by: AndreaBartolini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes OpenModelica Issue #12677