Skip to content

[Merged by Bors] - feat(CategoryTheory/Generator): introduce classes HasDetector and HasSeparator #18577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

datokrat
Copy link
Collaborator

@datokrat datokrat commented Nov 3, 2024

This change defines the typeclasses HasDetector and HasSeparator for categories with detectors/separators. Several results for IsDetector and IsSeparator are also proved for the new typeclasses.

Convenience theorems for proving the well-poweredness of categories with separators are added, too.

Two typos are fixed: "separating" is corrected to "coseparating" in the module docstring and IsCospearator.isCodetector is renamed to IsCoseparator.isCodetector.


Open in Gitpod

@datokrat datokrat added the WIP Work in progress label Nov 3, 2024
@github-actions github-actions bot added new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-category-theory Category theory labels Nov 3, 2024
Copy link

github-actions bot commented Nov 3, 2024

PR summary 7e958ef66e

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ HasCodetector
+ HasCodetector.hasCoseparator
+ HasCodetector.hasDetector_of_hasCodetector_op
+ HasCodetector.hasDetector_op
+ HasCoseparator
+ HasCoseparator.hasCodetector
+ HasCoseparator.hasSeparator_of_hasCoseparator_op
+ HasCoseparator.hasSeparator_op
+ HasDetector
+ HasDetector.hasCodetector_of_hasDetector_op
+ HasDetector.hasCodetector_op
+ HasDetector.hasSeparator
+ HasDetector.wellPowered
+ HasSeparator
+ HasSeparator.hasCoseparator_of_hasSeparator_op
+ HasSeparator.hasCoseparator_op
+ HasSeparator.hasDetector
+ HasSeparator.wellPowered
+ IsCoseparator.isCodetector
+ codetector
+ coseparator
+ detector
+ hasCodetector_op_iff
+ hasCoseparator_op_iff
+ hasDetector_op_iff
+ hasSeparator_op_iff
+ isCodetector_codetector
+ isCodetector_coseparator
+ isCoseparator_codetector
+ isCoseparator_coseparator
+ isDetector_detector
+ isDetector_separator
+ isSeparator_detector
+ isSeparator_separator
+ separator
+ wellPowered_of_isSeparator
- IsCospearator.isCodetector

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

@datokrat
Copy link
Collaborator Author

datokrat commented Nov 3, 2024

While wellPowered_of_isSeparator can be inlined quite trivially and might be unnecessary, I think HasSeparator.wellPowered can be actually useful. Happy to hear opinions on this :)

@datokrat datokrat removed the WIP Work in progress label Nov 3, 2024
@TwoFX TwoFX added the awaiting-author A reviewer has asked the author a question or requested changes. label Nov 4, 2024
@datokrat
Copy link
Collaborator Author

datokrat commented Nov 9, 2024

While applying the suggestions, I decided to make C implicit in hasSeparator_op_iff etc.. This way, one does not need to supply the category in hasSeparator_op_iff.mp proof_hasSeparator_C_op. I'd be interested what you think about that!

@datokrat datokrat added awaiting-CI and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 9, 2024
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 9, 2024

✌️ datokrat can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@datokrat
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Nov 10, 2024
…Separator (#18577)

This change defines the typeclasses `HasDetector` and `HasSeparator` for categories with detectors/separators. Several results for `IsDetector` and `IsSeparator` are also proved for the new typeclasses.

Convenience theorems for proving the well-poweredness of categories with separators are added, too.

Two typos are fixed: "separating" is corrected to "coseparating" in the module docstring and `IsCospearator.isCodetector` is renamed to `IsCoseparator.isCodetector`.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Nov 10, 2024

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title feat(CategoryTheory/Generator): introduce classes HasDetector and HasSeparator [Merged by Bors] - feat(CategoryTheory/Generator): introduce classes HasDetector and HasSeparator Nov 10, 2024
@mathlib-bors mathlib-bors bot closed this Nov 10, 2024
@mathlib-bors mathlib-bors bot deleted the datokrat/HasGenerator branch November 10, 2024 09:14
TobiasLeichtfried pushed a commit that referenced this pull request Nov 21, 2024
…Separator (#18577)

This change defines the typeclasses `HasDetector` and `HasSeparator` for categories with detectors/separators. Several results for `IsDetector` and `IsSeparator` are also proved for the new typeclasses.

Convenience theorems for proving the well-poweredness of categories with separators are added, too.

Two typos are fixed: "separating" is corrected to "coseparating" in the module docstring and `IsCospearator.isCodetector` is renamed to `IsCoseparator.isCodetector`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! t-category-theory Category theory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants