-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - chore: add some simp and fun_prop attributes #18874
Conversation
PR summary 7456389336Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit> The doc-module for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks innocuous, and useful enough. Two nits; please address before merging. Thanks!
maintainer delegate
🚀 Pull request has been placed on the maintainer queue by grunweg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out that these are not actually the most useful lemmas to tag with fun_prop
in practice (although doing these doesn't really hurt; I know mainly what you are adding is simp
. What you actually want are the compositional forms of all of these lemmas. That is: we actually want things like Differentiable.exp to be marked with fun_prop
. While we're here do you mind marking those accordingly?
I've noticed that the number of failures of I applied the |
bors merge |
* Also add a test file that uses the `simp` lemmas. * Add/move the `fun_prop` lemmas to the compositional lemmas. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Derivative.20cannot.20simp)
Pull request successfully merged into master. Build succeeded: |
* Also add a test file that uses the `simp` lemmas. * Add/move the `fun_prop` lemmas to the compositional lemmas. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Derivative.20cannot.20simp)
simp
lemmas.fun_prop
lemmas to the compositional lemmas.Zulip