Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add term offset support to the grind E-matching modulo #6533

Merged
merged 4 commits into from
Jan 5, 2025
Merged

feat: add term offset support to the grind E-matching modulo #6533

merged 4 commits into from
Jan 5, 2025

Conversation

leodemoura
Copy link
Member

This PR adds support to E-matching offset patterns. For example, we want to be able to E-match the pattern f (#0 + 1) with term f (a + 2).

@leodemoura
feat: add term offset support to the grind E-matching modulo
dd5a1ea 
This PR adds support to E-matching offset patterns. For example,
we want to be able to E-match the pattern `f (#0 + 1)` with term
`f (a + 2)`.
@leodemoura leodemoura requested a review from kim-em as a code owner January 5, 2025 01:44
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 5, 2025 01:52 Inactive
@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Jan 5, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 5, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase d22233fc7b9b865905cdd55d40498b983d765543 --onto 639e6e92a47df90000b95d7f092ae42acd7aabea. (2025-01-05 02:03:30)

@leodemoura leodemoura enabled auto-merge January 5, 2025 02:06
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 5, 2025 02:13 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jan 5, 2025
Merged via the queue into master with commit dc5c809 Jan 5, 2025
15 checks passed
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Jan 21, 2025
@leodemoura @luisacicolini
feat: add term offset support to the grind E-matching modulo (leanp…
1b2518e 
…rover#6533)

This PR adds support to E-matching offset patterns. For example, we want
to be able to E-match the pattern `f (#0 + 1)` with term `f (a + 2)`.
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
@leodemoura @JovanGerb
feat: add term offset support to the grind E-matching modulo (leanp…
a038802 
…rover#6533)

This PR adds support to E-matching offset patterns. For example, we want
to be able to E-match the pattern `f (#0 + 1)` with term `f (a + 2)`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot