Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support UIntX and USize in bv_decide #6711

Merged
merged 7 commits into from
Jan 29, 2025
Merged

feat: support UIntX and USize in bv_decide #6711

merged 7 commits into from
Jan 29, 2025

Conversation

hargoniX
Copy link
Contributor

This PR adds support for UIntX and USize in bv_decide by adding a preprocessor that turns them into BitVec of their corresponding size.

@hargoniX hargoniX added the changelog-language Language features, tactics, and metaprograms label Jan 20, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 20, 2025 09:24 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jan 20, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Jan 20, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1d03cd6a6b9e2cab387692f5ec0d0013b9a9867d --onto 74bd40d34d1a969da65007939960c2fefd461f08. (2025-01-20 09:40:41)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 1d03cd6a6b9e2cab387692f5ec0d0013b9a9867d --onto ac6a29ee834ba7fd30e9372e51493d7741e9c657. (2025-01-20 20:10:01)
  • ✅ Mathlib branch lean-pr-testing-6711 has successfully built against this PR. (2025-01-29 11:56:23) View Log
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3c8cf7a90546e2f84daf8d392aab8cde3ae944e0 --onto 20c616503abe5ce4253c56dbcd7766a91c675ba0. (2025-01-29 14:29:33)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0c43f0504733f44add6bfd22e5d7ad62fb0cb84b --onto 20c616503abe5ce4253c56dbcd7766a91c675ba0. (2025-01-29 15:45:42)

@hargoniX hargoniX force-pushed the hbv/bv_decide_uint branch 2 times, most recently from 000e0ca to 1920317 Compare January 27, 2025 09:01
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Jan 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6711
f50f85a
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Jan 29, 2025
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#6711
fd620c3
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Jan 29, 2025
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 29, 2025 13:58 Inactive
@hargoniX hargoniX marked this pull request as ready for review January 29, 2025 14:02
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 29, 2025 14:15 Inactive
@hargoniX hargoniX enabled auto-merge January 29, 2025 15:11
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc January 29, 2025 15:24 Inactive
@hargoniX hargoniX added this pull request to the merge queue Jan 29, 2025
Merged via the queue into master with commit c7dec60 Jan 29, 2025
15 checks passed
@hargoniX hargoniX deleted the hbv/bv_decide_uint branch January 29, 2025 18:11
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 24, 2025
@hargoniX @luisacicolini
feat: support UIntX and USize in bv_decide (leanprover#6711)
225acb3 
This PR adds support for `UIntX` and `USize` in `bv_decide` by adding a
preprocessor that turns them into `BitVec` of their corresponding size.
luisacicolini pushed a commit to opencompl/lean4 that referenced this pull request Feb 25, 2025
@hargoniX @luisacicolini
feat: support UIntX and USize in bv_decide (leanprover#6711)
b5b3682 
This PR adds support for `UIntX` and `USize` in `bv_decide` by adding a
preprocessor that turns them into `BitVec` of their corresponding size.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hargoniX @leanprover-community-bot