Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies and test matrix for Python 3.13. #12746

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 24, 2024

Summary

  • Add cgi forward port compatibility patch.
  • Upgrade morango

References

Fixes #12682

Reviewer guidance

Do tests pass for the new Python version?
Does the server pass a smoke test in Python 3.13?

The updated version of Morango updates the dependency we use for cryptography on some devices. To test this, install Python 3.13 on a Windows VM, then install the Kolibri windows asset from this PR - hopefully that should try to use the existing Python 3.13 installation.

Then run the server, and go through setup, then register and sync the server with KDP. If that all works, this should be good to go!

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment DEV: backend Python, databases, networking, filesystem... labels Oct 24, 2024
@pcenov
Copy link
Member

pcenov commented Mar 11, 2025

Hi @rtibbles after repeatedly trying to install this build on several VMs (on which I had installed only Python 3.13) and always being prompted to install Python 3.8.10 instead, I found that in https://github.com/learningequality/kolibri-installer-windows/pull/218/files we have the following code:

  // Check if Python is installed
  PythonCoreKey := 'SOFTWARE\Python\PythonCore\';
  MinSupportedVersion:=6;
  MaxSupportedVersion:=11;
  PythonPath:= '';
  PythonExists := False;

So it seems that you will have to change the limit set in MaxSupportedVersion:=11; to allow the installation of Python 13 so that I can test it.

@rtibbles
Copy link
Member Author

Thanks @pcenov as I was writing these instructions a little voice in the back of my head did whisper to me that this might be the case, but I unwisely ignored it.

I guess I have more fun ahead of me!

@rtibbles
Copy link
Member Author

Hi @pcenov I've updated the PR to build with a newer version of the Windows Installer that should accept Python 3.13! Apologies for the inconvenience!

@pcenov
Copy link
Member

pcenov commented Mar 13, 2025

Hi @rtibbles - With Python 3.13 installed, in both Windows 11 and 10 I am just getting the following error message:

not-starting

In Windows 11 it doesn't even create the .kolibri folder, while in Windows 10 there's not much info in the logs: logs.zip

@rtibbles
Copy link
Member Author

Thanks @pcenov - looks like there was one more place where I needed to add error handling for this case. I have made the update and tested the installer on my Windows 10 machine with Python 3.13 installed, and am pretty confident it should be working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... DEV: dev-ops Continuous integration & deployment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Python 3.13 support
3 participants