-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies and test matrix for Python 3.13. #12746
base: develop
Are you sure you want to change the base?
Conversation
Build Artifacts
|
Hi @rtibbles after repeatedly trying to install this build on several VMs (on which I had installed only Python 3.13) and always being prompted to install Python 3.8.10 instead, I found that in https://github.com/learningequality/kolibri-installer-windows/pull/218/files we have the following code:
So it seems that you will have to change the limit set in |
Thanks @pcenov as I was writing these instructions a little voice in the back of my head did whisper to me that this might be the case, but I unwisely ignored it. I guess I have more fun ahead of me! |
Hi @pcenov I've updated the PR to build with a newer version of the Windows Installer that should accept Python 3.13! Apologies for the inconvenience! |
Add new migration for updated le-utils. Add cgi forward port compatibility patch.
…cies are mismatched.
Thanks @pcenov - looks like there was one more place where I needed to add error handling for this case. I have made the update and tested the installer on my Windows 10 machine with Python 3.13 installed, and am pretty confident it should be working now! |
Summary
References
Fixes #12682
Reviewer guidance
Do tests pass for the new Python version?
Does the server pass a smoke test in Python 3.13?
The updated version of Morango updates the dependency we use for cryptography on some devices. To test this, install Python 3.13 on a Windows VM, then install the Kolibri windows asset from this PR - hopefully that should try to use the existing Python 3.13 installation.
Then run the server, and go through setup, then register and sync the server with KDP. If that all works, this should be good to go!