remove the class name from the appbarr #13183
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
nucleogenesis
requested review from
nucleogenesis
and removed request for
nucleogenesis
marcellamaki
requested changes
Mar 11, 2025
There was a problem hiding this comment.
Hi @AllanOXDi - this is close, but you've removed the facility name (if displayed) in addition to the class name. We only would want to remove the class name logic.
You can try this out to see it in the UI by creating two facilities, and you'll see that the app bar label looks like Coach - My Facility - My Class sometimes. So, we want to keep Coach - My Facility, if get(facilities).length > 1
|
This should be fixed now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the class name from the app bar since the class name is included in page now
References
#13127