Fix: Show search & setting buttons at channel level in quiz resource selection #13198
Conversation
github-actions
bot
added
APP: Coach
Build Artifacts
|
nucleogenesis
changed the title
|
Hi @nucleogenesis - could you have a look while the build assets are not generated? |
|
Re-run triggered, should be good to go now (only APK is still building) @pcenov 🙂 |
|
Hi @nucleogenesis - unfortunately now if I have bookmarked resources then the "Settings" and "Search" buttons are duplicated:
|
| @@ -19,6 +19,25 @@ | |||
| </div> | |||
| </template> | |||
| <template #default="{ isScrolled }"> | |||
| <QuizResourceSelectionHeader | |||
There was a problem hiding this comment.
Hi @nucleogenesis! I think this should be solved in the context of the SelectionIndex component, there we already have the buttons and the search button handler, the only thing is that we dont show them when bookmarksCount === 0.
Adding this here makes that when we have bookmarks we see these buttons duplicated
And this issue also happens with lessons too, so it should be fixed there too. Fixing this in the SelectionIndex component should fix it for both of them because we use this component for lessons and quizzes 👐 .
There was a problem hiding this comment.
Whoops, seems like @pcenov and I were reviewing it at the same time 😆
There was a problem hiding this comment.
We are doubling down on everything! 😄
nucleogenesis
force-pushed
the
13144--fix--search-question-setting-buttons-at-channel-level
branch
from
140cd1c to
d497f89
Compare
|
I fixed a small bug I caused in #13060 and also have found a much simpler solution to the issue. Please test both Lesson & Quiz selection, with and without having a bookmark. |
| class="mb-24" | ||
| :settings="settings" | ||
| @searchClick="onSearchClick" | ||
| /> | ||
| <div |
There was a problem hiding this comment.
We will also need to take out these headers to fix it in lessons and for practice quizzes too 👐
And I guess in lessons we should render this string conditionally only if we have bookmarks https://github.com/nucleogenesis/kolibri/blob/d497f89cec0ebf7776ba4b5d32ebc403885314bd/kolibri/plugins/coach/assets/src/views/common/resourceSelection/subPages/SelectionIndex.vue#L19
There was a problem hiding this comment.
@AlexVelezLl just pushed a fix for these two, thanks a ton Alex!
nucleogenesis
force-pushed
the
13144--fix--search-question-setting-buttons-at-channel-level
branch
from
3f41e54 to
6862282
Compare
|
@pcenov @AlexVelezLl this should be ready for re-review if the checks pass |
|
Hi @nucleogenesis - if I don't have any bookmarks then when I try to select a practice quiz the "Search" button is missing: practice.quiz.mp4The rest is looking good! |
|
@pcenov if you can confirm the final fix here, that would be great! |
Summary
Uses
QuizResourceSelectionHeaderon the resource selection side panel's index (aka channels listing page) to display the filters & search buttons.References
Fixes #13144
Reviewer guidance
You should see Settings & Search filters at the top of the page listing the channels. They should work as expected.