Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a white background to drag and drop in the manage selected resou… #13206

Merged

Conversation

AllanOXDi
Copy link
Member

Summary

Adds white background to the drag and drop in the manage selected resources.

References

#13127

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Mar 13, 2025
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AllanOXDi! This looks like the right change! Although now that we have this, I am noticing that we dont have enough padding-top in the rows and is looking a bit tight while dragging the row:

image

I know this is not in the issue description, but can we make a little adjustment in the scope of this PR? And remove this marging-top on not of first type. And instead add a padding-top: 16px to the .resource-row class? (to all items, without excluding the first of type)

I think that will make the row look more spaced out while dragging the row.

@AllanOXDi
Copy link
Member Author

Fixed

@AllanOXDi AllanOXDi requested a review from AlexVelezLl March 17, 2025 11:12
Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @AllanOXDi!

@rtibbles rtibbles merged commit 376e93e into learningequality:develop Mar 17, 2025
36 checks passed
@AllanOXDi AllanOXDi deleted the adds-white-background-to-draggable branch March 17, 2025 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants