Skip initClassInfo request for quiz and lesson resource selection side panel subpages #13210
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
AlexVelezLl
force-pushed
the
add-sidepanelpages-to-skip-initClassInfo
branch
from
7ba1ec0 to
c19e4d5
Compare
Build Artifacts
|
rtibbles
reviewed
Mar 13, 2025
There was a problem hiding this comment.
This makes sense from a code point of view, and I wasn't able to observe any regressions (although it was a little limited because of the bug that has just been resolved in develop for Quiz resource navigation). A rebase and quick manual QA confirmation should leave this good to go.
AlexVelezLl
force-pushed
the
add-sidepanelpages-to-skip-initClassInfo
branch
from
c19e4d5 to
51549f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Before:
Compartir.pantalla.-.2025-03-12.15_37_54.mp4
After:
Compartir.pantalla.-.2025-03-13.13_26_31.mp4
Reviewer guidance
Go through the quiz and lessons resource selection workflows, notice that the flow is smoother in slow networks, refresh the pages while on the side panel, and check that nothing breaks when you close the side panel.