Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate core logic of deletecontent and exportcontent to a util function #13211

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

thesujai
Copy link
Contributor

@thesujai thesujai commented Mar 13, 2025

Summary

This refactors the exportcontent and exportcontent commands and its related tasks

  • Moved the exportcontent core logic to export_content util function
  • Updated the diskexport task to use export_content instead of calling exportcontent command
  • Moved the deletecontent core logic to delete_content util function
  • Updated deletechannel task to user delete_content

References

Fixes #13209
Fixes #13208

Reviewer guidance

  • Try soft delete and force delete a content
  • Export a channel contents to a file

@thesujai thesujai marked this pull request as ready for review March 14, 2025 19:25
@thesujai
Copy link
Contributor Author

Hi @rtibbles, marking this as ready for review

@MisRob MisRob requested a review from rtibbles March 17, 2025 09:47
@MisRob MisRob added the TODO: needs review Waiting for review label Mar 17, 2025
@MisRob
Copy link
Member

MisRob commented Mar 17, 2025

Thanks @thesujai! We will review in the upcoming weeks. I wanted to note that review waiting times are still longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: backend Python, databases, networking, filesystem... TODO: needs review Waiting for review
Projects
None yet
2 participants