Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupWizard: Fix import facility superuser password #13213

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

nucleogenesis
Copy link
Member

@nucleogenesis nucleogenesis commented Mar 13, 2025

Summary

In UserCredentialsForm we were just emitting a submit event with no data, which I found meant that of the internals of SelectSuperAdminAccountForm were thought to be doing some things they weren't w/ the password data.

Also fixes some refs to the password textbox.


Weirdness Note

  • I spent a while trying to figure out why the page refreshes when the password is invalid but couldn't work it out. I don't think this is a bug that needs to be fixed here, but I can make a follow-up

References

Fixes #13103

Reviewer guidance

You must import from a device that has multiiple facilities on it. The reported bug does not replicate unless the device you import from has multiple facilities

1

  • Import a facility via the Full device import flow in Setup
  • After import, see that when you put a password in for the admin you used to authorize the import, there are no errors and you are redirected as expect.

2

  • Import a facility the same way again
  • After import, see that you can successfully create a new superuser

3

  • Regression test On My Own flow

@github-actions github-actions bot added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend labels Mar 13, 2025
@nucleogenesis nucleogenesis requested review from pcenov and LianaHarris360 and removed request for LianaHarris360 March 13, 2025 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup Wizard : 'Password field is empty in FacilityImportResource.grantsuperuserpermissions API call'
1 participant