Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 3.10 support by fixing PyInquirer dependency #25

Merged
merged 4 commits into from
Sep 27, 2022

Conversation

vinlin24
Copy link
Contributor

Users with Python 3.10+ installed face issue #23 caused by the PyInquirer dependency. However, I noticed that this issue is only present in the PyPI release. The official GitHub repository, although not updated for a while, is ahead of this release and supports 3.10, so I simply changed the dependency in setup.py to pull from this repo instead of from PyPI. Expectedly, this affects the files:

  • setup.py
  • cli/commands/auth.py
  • cli/commands/devices.py

I also made a change to cli/spotify.py since the --version flag implemented by click.version_info would fail to detect the package name. I don't know if this issue is unique to my development environment, but I updated the decorator just in case. Users still see the same output, spotify-cli, version X.Y.Z.

Copy link
Owner

@ledesmablt ledesmablt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much, LGTM. i'll handle the deployment since I do it manually =)

@ledesmablt ledesmablt merged commit cfd94cc into ledesmablt:master Sep 27, 2022
@ledesmablt
Copy link
Owner

Hello @vinlin24 , looks like your changes to the setup.py file aren't acceptable to pypi. Unfortunately I'll have to revert this. Build error linked below.

Am considering just using click or a simpler library instead of pyinquirer, but I don't have the time for it right now. Just voicing out some thoughts in case you or anyone else is up to it!

https://github.com/ledesmablt/spotify-cli/actions/runs/3135206863/jobs/5090622155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants