Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnLoad callback #41

Merged
merged 4 commits into from
Sep 14, 2017
Merged

OnLoad callback #41

merged 4 commits into from
Sep 14, 2017

Conversation

tulsileathers
Copy link
Contributor

@tulsileathers tulsileathers commented Sep 8, 2017

as discussed in #40

@prabhasp
Copy link

prabhasp commented Sep 12, 2017

Please merge :)
I've started using react-sound recently, and onLoad is a very useful feature to have. In my case, I sometimes re-render a Sound object referring to a file that was already loaded by sound-manager2 before, and onLoading doesn't even get called on those re-renders, whereas onload does, as I see in the console.log.

@tulsileathers
Copy link
Contributor Author

@leoasis

@leoasis
Copy link
Owner

leoasis commented Sep 14, 2017

Sorry for the delay, been quite busy. Thanks for the contribution!

@leoasis leoasis merged commit c6c9d04 into leoasis:master Sep 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants