Add error handling to sound object #50
Merged
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peinguin
approved these changes
Nov 26, 2017
leoasis
requested changes
Nov 27, 2017
src/index.js
Outdated
| @@ -154,6 +156,9 @@ export default class Sound extends React.Component { | |||
| whileplaying() { | |||
| props.onPlaying(this); | |||
| }, | |||
| onerror() { | |||
There was a problem hiding this comment.
This event receives some useful parameters, such as the error number
and description (http://www.schillmania.com/projects/soundmanager2/doc/#smsound-onerror). Maybe we could add them as parameters in the callback prop? we could do:
props.onError(errorCode, description, this)There was a problem hiding this comment.
Sweet. Sounds good. I'll get around to this later on today, then resubmit 👌
README.md
Outdated
| @@ -62,6 +62,7 @@ class MyComponentWithSound extends React.Component { | |||
| * *volume (number)*: The current sound's volume. A value between 0 and 100. | |||
| * *autoLoad (boolean)*: If the sound should start loading automatically (defaults to `false`). | |||
| * *loop (boolean)*: If the sound should continue playing in a loop (defaults to `false`). | |||
| * *onError (function)*: Function that gets called when the sound fails to load, or fails during load or playback. | |||
There was a problem hiding this comment.
We should explain that is received in this function
|
@leoasis Ok I made the updates! |
leoasis
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some error handling would be nice :)