Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lib] NeoPixelBus_Wrapper: Allow fall-back to Adafruit_NeoPixel lib for ESP8266 #4922

Conversation

tonhuisman
Copy link
Contributor

@tonhuisman tonhuisman commented Dec 27, 2023

Resolves #4921

Bugfix

Features:

  • Make GPIO selection on ESP8266 working again for NeoPixel plugins (except for P128 that never had that option on ESP8266 builds)
  • Allow compilation of NeoPixelBus_Wrapper library using Adafruit_NeoPixel library for ESP8266 only
  • Add (restore) latest Adafruit_NeoPixel library (+ corrected a few compiler warnings)
  • Exclude Adafruit_NeoPixel library from ESP32 builds (not used)
  • [P131] Fix compilation warning (-Wreorder)

TODO:

@fly74
Copy link

fly74 commented Dec 27, 2023

I have only gpio2 wired 8266. I can only test if it still works.

@tonhuisman
Copy link
Contributor Author

I can only test if it still works.

That's also valuable 👍

@chemmex
Copy link

chemmex commented Dec 27, 2023

First try - onboard LED at GPIO2 is gone, but NeoPixel at GPIO14 is dark. Using P038

@tonhuisman
Copy link
Contributor Author

Ah, found my mistake (not very experienced C++ programmer here...), will push a fix shortly.

@chemmex
Copy link

chemmex commented Dec 27, 2023

It works!

@fly74
Copy link

fly74 commented Dec 28, 2023

No issues with a gpio-2 wired 8266 with https://github.com/letscontrolit/ESPEasy/actions/runs/7342236014

@chemmex
Copy link

chemmex commented Dec 28, 2023

Just compiled a new custom build, everything is Ok so far

@TD-er TD-er merged commit a34ad10 into letscontrolit:mega Dec 28, 2023
@tonhuisman tonhuisman deleted the bugfix/NeoPixelBus_Wrapper-enable-adafruit_neopixel-fallback-build branch December 28, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [NeoPixel] [ESP8266] NeoPixel plugins are fixed on GPIO-2 since NeoPixelBus_Wrapper was introduced
4 participants