Skip to content

Remove PHP-Parallel-Lint #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2020
Merged

Remove PHP-Parallel-Lint #65

merged 2 commits into from
Mar 4, 2020

Conversation

nicwortel
Copy link
Contributor

@nicwortel nicwortel commented Mar 4, 2020

PHPStan will also report syntax errors, so running PHP-Parallel-Lint is redundant.

  • The pull request is complete according to the Definition of Done
    • Acceptance criteria in the ticket have been met
    • Automated tests are written according to the test plan
    • The documentation is up-to-date
    • Deployment automation includes newly introduced environment variables and credentials are added to the credentials.fact file of all servers
  • The pull request has a descriptive title that describes what has changed, and provides enough context for the changelog
  • When applicable, the pull request title starts with the issue number

PHPStan will also report syntax errors, so running PHP-Parallel-Lint is redundant.
@nicwortel nicwortel requested a review from a team March 4, 2020 10:18
@nicwortel nicwortel merged commit 12815b4 into master Mar 4, 2020
@nicwortel nicwortel deleted the remove-parallel-lint branch March 4, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants