Fix error when missing .release-tool/auth.yml #69
Conversation
src/Console/Application.php
Outdated
| throw new RuntimeException( | ||
| sprintf('The file %s needs to exist and contain a GitHub access token', $configFile) | ||
| ); | ||
| exit(sprintf('The file %s needs to exist and contain a GitHub access token.' . PHP_EOL, $configFile)); |
There was a problem hiding this comment.
I feel we should allow the file to be created when it does not exist.
There was a problem hiding this comment.
I'm afraid that just creating the file doesn't help that much, because a couple lines down the config file is being processed and afterwards the code is expecting that $processedConfiguration['github']['token'] is available.
Maybe adding a release-tool config credentials.github XXXXXXXXXXXXXXXXXXXXXXX command, just like composer has, will offer a nice developer experience. In that case you can keep the error message with the exit and just refer to the config command to properly configure the credentials.
There was a problem hiding this comment.
I agree. I meant to interactively generate the file and ask for the token.
But maybe directing the user to another command is cleaner.
src/Console/Application.php
Outdated
| throw new RuntimeException( | ||
| sprintf('The file %s needs to exist and contain a GitHub access token', $configFile) | ||
| ); | ||
| exit(sprintf('The file %s needs to exist and contain a GitHub access token.' . PHP_EOL, $configFile)); |
There was a problem hiding this comment.
This feels like a HTTP 200 OK response with a error message in the body. This error message is way better than a complete exception stack trace but we should not pretend that nothing happend and stop with a clean exit.
At least a exit(1) (https://tldp.org/LDP/abs/html/exitcodes.html) should be used to let the terminal, and user, know that an error has occurred.
tlsvda
force-pushed
the
fix-error-missing-auth-yaml
branch
from
b2a327d to
ca2441b
Compare
[#61] It has to show a cleaner error when .release-tool/auth.yml is missing.
tlsvda
force-pushed
the
fix-error-missing-auth-yaml
branch
from
ca2441b to
e0d9e19
Compare
[#61]
It has to show a cleaner error when .release-tool/auth.yml is missing.