Skip to content

LPD-10211: Migrate from Travis-CI to GitHub Actions #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2020
Merged

LPD-10211: Migrate from Travis-CI to GitHub Actions #70

merged 1 commit into from
Dec 3, 2020

Conversation

tlsvda
Copy link
Contributor

@tlsvda tlsvda commented Nov 30, 2020

No description provided.

@tlsvda tlsvda force-pushed the master_git_actions branch 16 times, most recently from 5c8e67e to 9c888b0 Compare November 30, 2020 12:56
@tlsvda tlsvda requested a review from a team November 30, 2020 13:14
christiaan
christiaan reviewed Nov 30, 2020
View reviewed changes
@tlsvda tlsvda force-pushed the master_git_actions branch from 9c888b0 to 7aa6333 Compare November 30, 2020 14:00
@tlsvda tlsvda requested a review from christiaan November 30, 2020 14:01
@tlsvda tlsvda requested a review from christiaan December 1, 2020 07:35
denniscoorn
denniscoorn previously approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@denniscoorn denniscoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

christiaan
christiaan requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@christiaan christiaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Phar file still needs to be built and added to the release.

@denniscoorn
Copy link
Contributor

The Phar file still needs to be built and added to the release.

Oops, indeed. I've missed that part. Good call 👍

@tlsvda tlsvda force-pushed the master_git_actions branch 2 times, most recently from 4d83b7a to 5b26944 Compare December 3, 2020 12:57
@tlsvda tlsvda force-pushed the master_git_actions branch from 5b26944 to 6fc9a70 Compare December 3, 2020 13:01
@tlsvda tlsvda merged commit 85f3c38 into master Dec 3, 2020
@tlsvda tlsvda deleted the master_git_actions branch December 3, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivammathur shivammathur shivammathur left review comments

@christiaan christiaan christiaan approved these changes

@denniscoorn denniscoorn denniscoorn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tlsvda @denniscoorn @christiaan @shivammathur