Exclude merge PRs from changelog with filter #77
Conversation
tlsvda
force-pushed
the
master_exclude-merge-prs-from-changelog
branch
2 times, most recently
from
fe2e6d2 to
0da9dd0
Compare
| $style->listing($this->changelogGenerator->getUnreleasedChangelog()->getUnreleasedChanges()); | ||
|
|
||
| $filteredChangeLogElements = $this->filterChangeLogElements( | ||
| $this->changelogGenerator->getUnreleasedChangelog()->getUnreleasedChanges() |
There was a problem hiding this comment.
Filtering the merge requests is not a responsibility of this class.
I feel this logic should be included inside the change log generator class that is being used.
That will also remove the need for the extra check in the markdownFormatter since that will only format anything that is inside the Changelog which is being returned from the ChangeLogGenerator.
Maybe even better would be if this was an optional configuration for our changelog generator, but lets not include that in the scope for now.
There was a problem hiding this comment.
You mean this file: PullRequestChangelogGenerator.php
This is already an optional configuration, this is only for PRs & Commit with specifically [MERGE] in the title
There was a problem hiding this comment.
Its optional to use; Not an optional configuration.
As this is an open-source project, some users might have a workflow that includes merges. Or they would want to use a different tag to specify merge requests with.
Maybe this issue is only specific with our workflow and others don't even need it. Maybe they are doing trunk-based development?
Those kind of questions mean that this feature requires a little more thought; Now, or later.
tlsvda
force-pushed
the
master_exclude-merge-prs-from-changelog
branch
2 times, most recently
from
1633b19 to
3240415
Compare
tlsvda
force-pushed
the
master_exclude-merge-prs-from-changelog
branch
from
3240415 to
3512c52
Compare
No description provided.