Skip to content

fix build in win32 #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 23, 2021
Merged

fix build in win32 #116

merged 5 commits into from
Jan 23, 2021

Conversation

slyshykO
Copy link
Contributor

tested for MinGW-gcc 8.3 and MSVC2017

Copy link

@OgreTransporter OgreTransporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in CMake are necessary for building with Visual Studio. The library 'm' for example does not exist.

@bukka
Copy link
Member

bukka commented Dec 27, 2020

Why is this actually needs to rename all google tests?

@slyshykO
Copy link
Contributor Author

Why is this actually needs to rename all google tests?

This question need address to google because I just update gogletest lib.

@bukka
Copy link
Member

bukka commented Jan 3, 2021

Ah sorry those are the libs ones. That's of course fine.

I have just tried to build it but getting:

CMake Warning at lib/googletest/CMakeLists.txt:47 (project):
  VERSION keyword not followed by a value or was followed by a value that
  expanded to nothing.

which wasn't the case before this change. Doesn't this need to set explicitly GOOGLETEST_VERSION variable?

@bukka
Copy link
Member

bukka commented Jan 3, 2021

I should say that I build on Linux with cmake 3.16.3.

@slyshykO
Copy link
Contributor Author

slyshykO commented Jan 3, 2021

Doesn't this need to set explicitly GOOGLETEST_VERSION variable?

Think no, cause all builds are successful, and all tests passed.

@slyshykO
Copy link
Contributor Author

slyshykO commented Jan 3, 2021

@bukka, should I update googletest to lastest version (1.10)?

@bukka
Copy link
Member

bukka commented Jan 3, 2021

Basically the line that is giving warning is

project(gtest VERSION ${GOOGLETEST_VERSION} LANGUAGES CXX C)

so I guess that has changed and might require the GOOGLETEST_VERSION variable to be set. It won't probably prevent to run it (that's why warning) but it would be good to check what should be done about that as I would like to keep it without any warning.

@bukka
Copy link
Member

bukka commented Jan 3, 2021

Looks like the 1.10 doesn't have it when looking to https://github.com/google/googletest/blob/release-1.10.0/CMakeLists.txt so it might actually help to update it. Looks like even update to 1.8 should help so anything above should be fine. I would go for the latest that works though so if 1.10 works, then go for it.

@slyshykO
Copy link
Contributor Author

slyshykO commented Jan 3, 2021

Actually, line with VERSION there https://github.com/google/googletest/blob/release-1.10.0/googletest/CMakeLists.txt#L54 .
Look like I didn't copy all project.

I would go for the latest that works

So, I try to update to 1.10

@bukka bukka merged commit d741a9e into libfann:master Jan 23, 2021
@bukka
Copy link
Member

bukka commented Jan 23, 2021

Tested and now warnings now! Merged thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants